Skip to content

Upgrade to OpenEthereum 2.7.2#3595

Merged
evgenykuzyakov merged 1 commit into
evm-precompilefrom
evm-upgrade-2.7.2
Nov 12, 2020
Merged

Upgrade to OpenEthereum 2.7.2#3595
evgenykuzyakov merged 1 commit into
evm-precompilefrom
evm-upgrade-2.7.2

Conversation

@artob
Copy link
Copy Markdown
Contributor

@artob artob commented Nov 12, 2020

As the next step in #3506, and following up from #3542 and #3558, upgrade Parity Ethereum (now OpenEthereum) from 2.6.8 (Dec 2019) to 2.7.2 (Feb 2020), the last release in the 2.x series.

This harmonizes our dependency graph with upstream, fixing numerous build errors from the upgrade and eliminating multiple versions of the same crates. This concerns the bn, ethabi, ethabi-contract, ethabi-derive, ethereum-types, keccak-hash, primitive-types, and uint crates as well as their transitive dependencies and their interdependencies.

The near/bn fork exists to upgrade bn's rand dependency. That's necessary because of a particularly complex dependency issue (rust-random/rand#645) in old versions of rand. We will eliminate the fork going forward once upstream upgrades their dependency (I will open a pull request for them).

The upstream changelog for 2.7.2 is at: https://github.com/openethereum/openethereum/blob/v2.7.2/CHANGELOG.md

The upstream diff from 2.6.8 to 2.7.2 is at: openethereum/openethereum@v2.6.8...v2.7.2

@artob artob added C-enhancement Category: An issue proposing an enhancement or a PR with one. C-housekeeping Category: Refactoring, cleanups, code quality A-EVM Area: Native EVM implementation and support C-dependencies Category: Pull requests that update a dependency file labels Nov 12, 2020
@evgenykuzyakov
Copy link
Copy Markdown
Contributor

Please make sure sanity-checks pass

@artob
Copy link
Copy Markdown
Contributor Author

artob commented Nov 12, 2020

@evgenykuzyakov Will do. Investigating...

Comment thread runtime/near-evm-runner/Cargo.toml Outdated
@artob artob force-pushed the evm-upgrade-2.7.2 branch from fe379b5 to 52590d8 Compare November 12, 2020 19:58
@artob artob requested a review from ailisp November 12, 2020 19:58
@artob artob force-pushed the evm-upgrade-2.7.2 branch from 52590d8 to 58dd176 Compare November 12, 2020 20:07
@artob
Copy link
Copy Markdown
Contributor Author

artob commented Nov 12, 2020

Please make sure sanity-checks pass

@evgenykuzyakov I updated deny.toml, and cargo deny check bans passes now.

@evgenykuzyakov evgenykuzyakov merged commit 8a45140 into evm-precompile Nov 12, 2020
@evgenykuzyakov evgenykuzyakov deleted the evm-upgrade-2.7.2 branch November 12, 2020 20:51
evgenykuzyakov pushed a commit that referenced this pull request Nov 17, 2020
This fixes #3611. The regression was due to an invalid `zombieAttack.bin` imported in e350e29 (#3299). Hereby reverted to the original from cc4ec1f.

Additionally, this also removes an annoying build warning inadvertently introduced in 8a45140 (#3595).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-EVM Area: Native EVM implementation and support C-dependencies Category: Pull requests that update a dependency file C-enhancement Category: An issue proposing an enhancement or a PR with one. C-housekeeping Category: Refactoring, cleanups, code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants