feat (runtime): Wasmer ExceptionCode support #2505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore into fckt/wasmer-16-update
…ore into fckt/wasmer-16-update
…ore into fckt/wasmer-16-update
…ror cases form Wasmer
…ore into fckt/wasmer-16-update
lexfrl
requested review from
evgenykuzyakov,
frol and
MaksymZavershynskyi
as code owners
|
|
lexfrl
force-pushed
the
fckt/wasmer-exception-code
branch
2 times, most recently
from
a4a71b2 to
e5d7efc
Compare
lexfrl
force-pushed
the
fckt/wasmer-exception-code
branch
from
e5d7efc to
7de946b
Compare
…nearcore into fckt/wasmer-exception-code
frol
approved these changes
Apr 20, 2020
|
@frol For example, when we'll updated to a fixed Wasmer version this test will fail (since the call will return |
evgenykuzyakov
approved these changes
Apr 21, 2020
Closed
nearprotocol-bulldozer bot
pushed a commit
that referenced
this pull request
Apr 28, 2020
Due to wasmerio/wasmer#1409 we need to rollback Wasmer to older version. I am replacing some of Wasmer generated error with Unknown to avoid undoing too much code from this PR: #2505 After the following PR lands wasmerio/wasmer#1401 we would need to revisit error handling from Wasmer anyway. CC @fckt ### Testing Ran near-evm test. CI passes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #2332
The PR just adds Wasmer ExceptionCode support, introduced in Wasmer 0.16. Introduces new Tx Error types, so chain/jsonrpc/res/rpc_errors_schema.json updated.
FunctionCallError::WasmUnknownErrorintroduced.Wasmer never returns ExceptionCode today (at least for a single-pass), that's why tests for traps return
FunctionCallError::WasmUnknownError.wasmerio/wasmer#1338