Stabilize NEP-488 (Host Functions for BLS12-381 Curve Operations) #11818
Conversation
core/parameters/src/config_store.rs
Outdated
| @@ -45,8 +45,8 @@ static CONFIG_DIFFS: &[(ProtocolVersion, &str)] = &[ | |||
| (69, include_config!("69.yaml")), | |||
| // Introduce ETH-implicit accounts. | |||
| (70, include_config!("70.yaml")), | |||
| (71, include_config!("71.yaml")), | |||
There was a problem hiding this comment.
May or may not want to re-use protocol version 70, as the next mainnet release will be going up to 69. And 70 already comes in the release after the upcoming one. Doesn't matter much though, AFAIU protocol is now able to upgrade multiple protocol versions per release.
| "protocol_version": 70, | ||
| "protocol_version": 71, |
There was a problem hiding this comment.
We want to release BLS signatures as part of protocol version 70 release.
core/primitives-core/src/version.rs
Outdated
| ProtocolFeature::EthImplicitAccounts => 70, | ||
| ProtocolFeature::BLS12381 => 71, |
There was a problem hiding this comment.
We want BLS12381 feature to be released together with StatelessValidation. Similarly as protocol v69 contains several features.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11818 +/- ##
==========================================
+ Coverage 71.76% 71.79% +0.03%
==========================================
Files 796 796
Lines 163196 163213 +17
Branches 163196 163213 +17
==========================================
+ Hits 117115 117186 +71
+ Misses 41030 40983 -47
+ Partials 5051 5044 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
In this PR: #11818 the BLS12381 Feature was mistakenly included in version 69. In this PR, the feature has been moved to version 70.
Stabilize NEP-488: Host Functions for BLS12-381 Curve Operations