Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: rename function to reflect actual ability #11036

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

akhi3030
Copy link
Collaborator

Renames pub fn upgrade_protocol(&mut self, protocol_version: ProtocolVersion) to pub fn upgrade_protocol_to_latest_version(&mut self). The function is unable to upgrade to a specific version but instead always upgrades to the latest version.

Also see #8590.

@akhi3030 akhi3030 requested a review from a team as a code owner April 11, 2024 17:04
@akhi3030 akhi3030 requested a review from wacban April 11, 2024 17:04
@akhi3030 akhi3030 enabled auto-merge April 11, 2024 17:04
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.30%. Comparing base (f7604cd) to head (1f50112).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11036      +/-   ##
==========================================
+ Coverage   71.12%   71.30%   +0.17%     
==========================================
  Files         758      758              
  Lines      152602   152499     -103     
  Branches   152602   152499     -103     
==========================================
+ Hits       108544   108736     +192     
+ Misses      39608    39329     -279     
+ Partials     4450     4434      -16     
Flag Coverage Δ
backward-compatibility 0.24% <0.00%> (?)
db-migration 0.24% <0.00%> (?)
genesis-check 1.43% <0.00%> (?)
integration-tests 36.92% <100.00%> (+<0.01%) ⬆️
linux 69.79% <100.00%> (+0.11%) ⬆️
linux-nightly 70.76% <100.00%> (-0.04%) ⬇️
macos 54.40% <0.00%> (-0.03%) ⬇️
pytests 1.66% <0.00%> (?)
sanity-checks 1.45% <0.00%> (?)
unittests 66.96% <0.00%> (+<0.01%) ⬆️
upgradability 0.29% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wacban wacban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akhi3030 akhi3030 added this pull request to the merge queue Apr 12, 2024
Merged via the queue into near:master with commit 5550b4d Apr 12, 2024
28 of 29 checks passed
@akhi3030 akhi3030 deleted the upgrade-to-latest branch April 12, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants