Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved away from tla on testnet #369

Open
wants to merge 26 commits into
base: main
Choose a base branch
from

Conversation

AlexKushnir1
Copy link
Contributor

Renamed method (create_tla) and added .testnet to the randomly generated ID sent to the helper when creating a dev account

@AlexKushnir1
Copy link
Contributor Author

@race-of-sloths

@race-of-sloths
Copy link

race-of-sloths commented Aug 9, 2024

@AlexKushnir1 Thank you for your contribution! Your pull request is now a part of the Race of Sloths!

Shows profile picture for the author of the PR

Current status: stale

This pull request was removed from the race, but you can include it again with @race-of-sloths include command

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

workspaces/tests/account.rs Show resolved Hide resolved
workspaces/src/network/variants.rs Outdated Show resolved Hide resolved
workspaces/src/network/testnet.rs Outdated Show resolved Hide resolved
workspaces/src/network/testnet.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlexKushnir1 Great job! We are getting very close to solving it once and for all!

@race-of-sloths score 13

Comment on lines 36 to 44
let res = worker
.delete_account(sub.id(), sub.signer(), &worker.info().root_id)
.await?;
assert!(res.is_success());

let res = worker
.delete_account(account.id(), account.signer(), &worker.info().root_id)
.await?;
assert!(res.is_success());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing tests must clean up the accounts as well to avoid draining the faucet account.

Just for context, the previous comment on this topic was here: https://github.com/near/near-workspaces-rs/pull/369/files#r1713257285, please, either fix the drainage or go back to sandbox.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Returned to the sandbox. The main idea of ​​staying on testnet was that there are no tests on testnet

workspaces/src/network/variants.rs Outdated Show resolved Hide resolved
workspaces/src/network/variants.rs Outdated Show resolved Hide resolved
@race-of-sloths
Copy link

❌ PR inactive

This PR has been inactive for two weeks. It's now marked as stale.

Tip

If you think it's a mistake, you can restart the bot with include command to proceed 🔄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants