chore: put legacy collections under feature flag#923
Merged
Conversation
austinabell
requested review from
ChaoticTempest and
itegulov
as code owners
ChaoticTempest
approved these changes
Oct 18, 2022
Contributor
ChaoticTempest
left a comment
ChaoticTempest
left a comment
There was a problem hiding this comment.
hmm, that one test failure for simulate_simple_approve seems weird, but maybe bringing up at least 16 sandbox nodes at the same time could make it very slow. Did you ever try upping the timeout seconds?
| - run: rustup target add wasm32-unknown-unknown | ||
| - name: Test | ||
| run: cargo test --all --features unstable | ||
| run: cargo test --all --features unstable --features legacy |
Contributor
There was a problem hiding this comment.
optional: it's kinda weird that --features can be supplied multiple times like this. Normally I just put --features unstable,legacy, but up to you
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #869
This doesn't functionally change anything because it's enabled by default, but allows devs to remove this section, and this will be deprecated in the next major version