docs(Upgradable): remove confusing statement#97
Merged
Merged
Conversation
birchmd
approved these changes
Mar 15, 2023
mrLSD
approved these changes
Dec 30, 2023
This was referenced Mar 27, 2026
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the
Upgradableplugin makes sense when there are no other ways to deploy code. Under that assumption stale staged code is equal to deployed code and the statement removed in this PR is confusing.With this change the section
# Stale staged codein the module documentation becomes very short. Still I think it makes sense to keep it there, to highlight the importance of handling stale staged code.