Make calls to trait methods fully qualified in acl plugin#21
Merged
Conversation
mooori
changed the title
mooori
commented
Oct 17, 2022
| @@ -1,10 +1,8 @@ | |||
| use near_plugins::events::AsEvent; | |||
Contributor
Author
There was a problem hiding this comment.
We'll no longer need to ask contract developers to do this (same for TryFrom below).
mfornet
approved these changes
Oct 18, 2022
mrLSD
approved these changes
Nov 22, 2023
This was referenced Mar 27, 2026
Closed
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously contract developers needed to bring traits into scope to allow the code generated for acl to call methods of some traits:
std::convert::TryFromfor methodtry_fromnear_plugins::events::AsEventfor methodemitIn this PR, calls to above methods are changed to fully qualified syntax. As a result, the traits no longer need to be brought into scope with
usestatements.