fix: replace invalid crates.io keyword and rename legacy changelog#185
Closed
r-near wants to merge 1 commit into
Closed
fix: replace invalid crates.io keyword and rename legacy changelog#185r-near wants to merge 1 commit into
r-near wants to merge 1 commit into
Conversation
"smart contract" (with space) is rejected by crates.io, causing all release-plz publish attempts to fail with a 400 Bad Request. Replace with "smart-contract". Rename CHANGELOG.md to CHANGELOG-legacy.md so release-plz can manage per-crate changelogs going forward without conflicts.
There was a problem hiding this comment.
Pull request overview
This PR addresses crates.io publishing failures by fixing an invalid workspace keyword and prepares the repository for release-plz-managed per-crate changelogs by moving the existing top-level changelog to a legacy file.
Changes:
- Replace the invalid crates.io keyword
"smart contract"with"smart-contract"in workspace package metadata. - Rename/move the existing changelog content into
CHANGELOG-legacy.mdto avoid conflicts with future per-crate changelogs.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Cargo.toml | Updates workspace keywords to a crates.io-valid value (smart-contract). |
| CHANGELOG-legacy.md | Adds the legacy changelog content under a new filename for archival/reference. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"smart contract"with"smart-contract"in workspace keywords — crates.io rejects keywords with spaces, which has been causing all release-plz publish attempts to fail with400 Bad Request: "smart contract" is an invalid keywordCHANGELOG.mdtoCHANGELOG-legacy.mdso release-plz can manage per-crate changelogs going forward without conflicts (previous releases were done manually)Context
All 3 Release-plz runs since the workflow was added have failed:
CARGO_REGISTRY_TOKENwasn't set (since fixed)"smart contract" is an invalid keyword(this PR)After this merges, the release-plz
releasejob should successfully publishnear-pluginsandnear-plugins-derivev0.5.1 to crates.io and create per-package git tags. PR #184 can be closed — release-plz will create a fresh one based on the new tags.Test plan
releasejob succeeds