Conversation
added 2 commits
October 11, 2022 20:37
mooori
reviewed
Oct 12, 2022
Comment on lines
+29
to
+31
| tokio = { version = "1", features = ["full"] } | ||
| # Feature `unstable` is required for compiling contracts during tests. | ||
| workspaces = { version = "0.6", features = ["unstable"] } |
Contributor
There was a problem hiding this comment.
Does specifying them in workspace.dependencies make them regular dependencies? Previously these (and some others) were only dev-dependencies. At least tokio probably shouldn't become a regular dependency.
Member
Author
There was a problem hiding this comment.
That's what I expect. Notice they are under dev-dependencies on the specific project: [dev-dependencies]
Contributor
There was a problem hiding this comment.
I couldn't find anything on it in cargo docs. Building a contract that uses plugins can be done by:
cd near-plugins/tests/contracts/access_controllable
cargo clean && rm Cargo.lock
make build
Afterwards tokio and other dev-dependencies are not in Cargo.lock. I think that confirms the expected behavior (they're not becoming regular dependencies).
mooori
approved these changes
Oct 12, 2022
mrLSD
approved these changes
Nov 19, 2023
This was referenced Mar 27, 2026
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use stable version of near-sdk