Conversation
karim-en
changed the title
frolvanya
approved these changes
Sep 11, 2024
Contributor
frolvanya
left a comment
frolvanya
left a comment
There was a problem hiding this comment.
There're small nitpicks like args.roles.len() == 0 -> !args.is_empty() or let err = format!("{}", err); -> let err = err.to_string();, but they're not that important, so can be ignored
olga24912
approved these changes
Sep 11, 2024
| .pausable_contract | ||
| .pa_pause_feature(&setup.pause_manager, "get_counter") | ||
| .await?; | ||
| assert_success_with(res, true); |
Contributor
There was a problem hiding this comment.
We should also call the get_counter as a view method to ensure that we are able to do so.
Collaborator
Author
There was a problem hiding this comment.
We already do a view call line below
2 tasks
This was referenced Mar 27, 2026
Closed
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
near-sdkversion to avoid auto upgrade that breaks CI and build due to dependencies conflicts.