feat: bump near-sdk to 5.1.0#134
Conversation
chore: make clippy happy
mooori
left a comment
There was a problem hiding this comment.
To follow the v5 docs of near-sdk, I think it would be good to use #[near] instead of #[near_bindgen] in the test/example contracts.
|
Strangely check |
|
I missed 542009b was pushed while I was reviewing. Will have to take a look at that before enabling merge. |
|
@mitinarseny what is the motivation for adding 542009b to this PR? |
|
I've just tried to use use near_plugins::{access_control, AccessControlRole, AccessControllable, Ownable, Pausable};
#[derive(AccessControlRole, Clone, Copy)]
pub enum Role {
// ...
}
#[access_control(role_type(Role))]
// #[derive(Ownable)], etc...
pub struct Contract {
// ...
}But I agree that it's not directly connected to "bumping near-sdk version". PS: I might need to rebase the whole branch to have my commits signed... Do you mind if I do it now and re-request your review? Sorry for that, didn't pay attention in the first place |
I want to avoid the force push and re-review, so I've disabled this requirement. |

No description provided.