Update toolchain and manifest to Rust 1.70.0#130
Closed
mikedotexe wants to merge 1 commit into
Closed
Conversation
Contributor
|
Thank you for bringing this up! We have workarounds for building with 1.69 and use them in CI, but missed to highlight them to users. We cannot yet bump the MSRV as some users of this crate still need to use Rust 1.69.0. To prevent issues like this, I’ve opened #131. After it lands, user with a toolchain >= 1.70.0 should not hit this issue anymore, as the override is removed from |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed this error when opening the repo:
So updated
Cargo.tomlandrust-toolchainin the project root from1.69.0»1.70.0This repo looks really amazing, btw, bravo!