build!: update Rust version and near-* dependencies#118
Conversation
near-* dependencies
There was a problem hiding this comment.
Could you please verify that it is still possible to build contracts with plugins using rust 1.69, because currently there is an issue with parsing the contracts by nearblocks if the rust version is 1.70 and higher.
Check this: https://github.com/aurora-is-near/rainbow-token-connector/pull/234/files
and this
near/nearcore#9143 (comment)
|
@karim-en thank you for bringing this up. As you were running into the same issue, I tried to figure out the underlying problem. See this issue. To verify |
|
Turns out that the failure to build As a result, the MSRV can be lowered to 1.69.0, which is used to compile test contracts and in CI. |
birchmd
left a comment
There was a problem hiding this comment.
This explicit downgrading of dependencies is a little awkward so if possible I think it would be nice to get the MSRV up to 1.70 (once this is possible for the bridge). But for now this looks like a good work-around.
Actually, the contracts that are built with 1.70 work correctly because the protocol itself has already been upgraded to support those contracts. |
|
I've opened #121 for the MSRV upgrade. |
With the current minimum
rust-versionof 1.64.0 tests cannot be built anymore, e.g. see this CI failure. Hence this PR increseasesrust-versionto1.70.01.69.0 and updatesnear-workspaces. An update of bothrust-versionandnear-workspacesis required to make tests build and pass again, hence this PR combines both.Why
1.70.01.69.0The latest version of
near-workspacesrequires at least Rust 1.69.0.BREAKING CHANGES
The minimum supported Rust version is increased from 1.64.0 to
1.70.01.69.0.near-workspacesnear-pluginsshould not be affected by this update since it is adev-dependencyonly used in tests.workspacestonear-workspacesand many lines in the diff are due to this change.near-sdkUpdating from
4.1.0to4.1.1since Near dependencies are already touched in this PR.Outlook
Some other dependencies had major versions bumps and we should update them as well. It might require some refactors, so I would suggest to that in separate PR(s). I will open a tracking issue shortly.