Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: serde_json::Value bridging example/doc #317

Merged
merged 9 commits into from
Oct 30, 2024

Conversation

dj8yfo
Copy link
Collaborator

@dj8yfo dj8yfo commented Oct 29, 2024

No description provided.

@dj8yfo dj8yfo marked this pull request as ready for review October 30, 2024 09:54
@dj8yfo dj8yfo requested a review from frol as a code owner October 30, 2024 09:54
@dj8yfo
Copy link
Collaborator Author

dj8yfo commented Oct 30, 2024

@race-of-sloths include

@race-of-sloths
Copy link

race-of-sloths commented Oct 30, 2024

@dj8yfo Thank you for your contribution! Your pull request is now a part of the Race of Sloths!

Shows inviting banner with latest news.

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@frol 5

Your contribution is much appreciated with a final score of 5!
You have received 55 (50 base + 10% lifetime bonus) Sloth points for this contribution

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@frol
Copy link
Collaborator

frol commented Oct 30, 2024

This example looks great to me, and I prefer it to be an example rather than a baked-in support for serde-json, which would create an odd dependency for borsh.

Before merging it, though, I would love to hear the feedback and thoughts of the original author of the PR.

@larry0x
Copy link

larry0x commented Oct 30, 2024

I would love to hear the feedback and thoughts of the original author of the PR.

@dj8yfo @frol This looks good to me, and the points you raised in #312 are valid.

Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@race-of-sloths score 5

@frol frol merged commit 21c024f into near:master Oct 30, 2024
7 checks passed
@frol frol mentioned this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants