Eliminate unsafe code from both ser and de of u8 #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgenykuzyakov
approved these changes
Mar 20, 2021
frol
approved these changes
Mar 20, 2021
|
@dtolnay Thank you for the fix! 💫 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17. Fixes #18. Closes #24.
It was a red flag to me that all the unsafe code in this crate was unsound. This PR reimplements the same optimized behavior for slices/arrays/vectors without needing any unsafe code.
The approach from #25 of hiding the trait method from docs but leaving it unsound (safe to call and safe to implement) does not seem like a satisfying fix to me.
Note that I have not touched one remaining unsafe code, which is still unsound (#19).