feat: max_size: various small refactoring #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mina86
force-pushed
the
b
branch
2 times, most recently
from
89d637b
to
8c00f72
Compare
* Change is_zero_size to short-circuit internal all function when first element which isn’t zero sized is found. * Change is_zero_size to use vector of str slices as stack. There’s no need to allocate strings. This also makes it possible to share the same stack as max_serialized_size_impl. * Introduce Recursive error type to better encode error condition of is_zero_size. * Change max_serialized_size’s count argument to NonZeroUsize to encode in type system that the count is in fact never zero. In places where it might end up zero, the function short-circuits.
dj8yfo
reviewed
Sep 18, 2023
| @@ -115,15 +115,25 @@ fn max_serialized_size_impl<'a>( | |||
| Ok(Definition::Array { length, elements }) => { | |||
| // Aggregate `count` and `length` to a single number. If this | |||
| // overflows, check if array’s element is zero-sized. | |||
| let count = usize::try_from(*length) | |||
| let count_lengths = usize::try_from(*length) | |||
There was a problem hiding this comment.
using the same count name everywhere was confusing to me
dj8yfo
approved these changes
Sep 18, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change is_zero_size to short-circuit internal all function when
first element which isn’t zero sized is found.
Change is_zero_size to use vector of str slices as stack. There’s
no need to allocate strings. This also makes it possible to share
the same stack as max_serialized_size_impl.
Introduce Recursive error type to better encode error condition of
is_zero_size.
Change max_serialized_size’s count argument to NonZeroUsize to
encode in type system that the count is in fact never zero. In
places where it might end up zero, the function short-circuits.
s/core::result::Result/Result/ since full path is no longer
necessary after the code moved to its own module.