Forbid Zero-sized types from deserialization #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frol
requested changes
Jun 5, 2023
There was a problem hiding this comment.
@iho Thanks for working on it! There are a couple of things:
- Test needs to be fixed (CI failed due to unused import in the test file)
- Let's also fail on the serialization of Vec, so there is symmetry and developers could catch errors (unfortunately, it seems there is no way to make the implementation generic over Vec in Rust, so we cannot catch it at compile time) - add/update a test for it as well
frol
approved these changes
Jun 6, 2023
Merged
|
Great! As soon as a release is published I will make sure that the RustSec advisory is updated. |
|
Looks like a release was made just a few days before this getting merged. Are we going to get a new release soon? |
|
@paolobarbolini I guess we will make release this week when I finish my PR and another one(pretty small). |
Closed
mina86
pushed a commit
to mina86/borsh-rs
that referenced
this pull request
Aug 23, 2024
…solve the RUSTSEC-2023-0033 (near#145)
frol
pushed a commit
that referenced
this pull request
Sep 23, 2024
* feat: Forbid Vectors of Zero-sized types from de-/serialization to resolve the RUSTSEC-2023-0033 (#145) This is a backport of commit e880d87. * chore: update MSRV and Cargo workspace syntax Set MSRV to 1.66 and update Cargo workspace syntax together with versions in members. While at it restrict serde dependency in two non-member crates so that it compiles with Rust 1.66. * chore: additional prepare for release --------- Co-authored-by: iho <[email protected]> Co-authored-by: Michal Nazarewicz <[email protected]> Co-authored-by: dj8yf0μl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves RUSTSEC-2023-0033
Resolves #19
Resolves #52