State Storage - State #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staffik
requested review from
wacban and
shreyan-gupta
and removed request for
a team
wacban
reviewed
Nov 5, 2024
There was a problem hiding this comment.
Looks great overall!
I think the implementation details can go into the reference implemention section. Can you add a more high level overview in specification and move the rest? Can you also mention what the naive / brute force approach would be and why it is not feasible?
wacban
reviewed
Nov 5, 2024
neps/nep-0568.md
Outdated
Comment on lines
131
to
135
| Mappings in `ShardUIdMapping` persist as long as any descendant shard still references the ancestor shard’s data. | ||
| When no descendants rely on a particular ancestor shard, its mapping entry can be removed, allowing the ancestor’s data to be garbage collected. | ||
| If a full state sync is performed for a child shard (downloading and storing all its data independently), | ||
| the mapping to the ancestor shard can also be removed, as the child’s data is now directly stored under its own `ShardUId`. | ||
|
|
There was a problem hiding this comment.
The cleanup shouldn't depend on state sync. I think we should cleanup the mapping when the node stops tracking all children / descendant shards. Also can you mention that the mapping will be permanent on archival nodes?
|
Once merged into the main PR, please check if there any any lints that need fixing and address those - feel free to commit directly, no need for another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.