Add macOS ARM64 build#1377
Merged
danielgarthur merged 1 commit intomasterfrom Apr 18, 2025
Merged
Conversation
e821363 to
200f68c
Compare
basil
commented
Apr 18, 2025
Comment on lines
+45
to
+50
| - name: Publish | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: Neanes-${{ matrix.os }} | ||
| path: dist/Neanes-* | ||
| retention-days: 3 |
Member
Author
There was a problem hiding this comment.
Not strictly needed for this PR, but needed for me to be able to test the CI build and seems useful more generally. Signing will not take place without setting CSC_FOR_PULL_REQUEST=true, and I used that during testing but did not retain it in the final version of this PR because of scary-looking security warnings printed to the logs. CSC_FOR_PULL_REQUEST should not be necessary for the release pipeline.
| "@vue/eslint-config-typescript": "^14.5.0", | ||
| "electron": "^35.1.5", | ||
| "electron-builder": "^26.0.12", | ||
| "electron-builder": "^26.0.13", |
Member
Author
There was a problem hiding this comment.
danielgarthur
approved these changes
Apr 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts cea1b32. Fixes #1371.
Testing done
With
CSC_FOR_PULL_REQUESTtemporarily set totrue, observed the expectedfrom electron-userland/electron-builder#9007. Downloaded the resulting
.dmgfile and installed to/Applications. Right-clicked and selected Open, saw "Neanes Not Opened: Apple could not verify Neanes is free of malware that may harm your Mac or compromise your privacy." (This is expected, and is better than the previous result of "damaged.") Went to Settings, Privacy & Security, saw "Neanes was blocked to protect your Mac," and clicked Open Anyway. Neanes launched and playback was fine.