Skip to content

Add macOS ARM64 build#1377

Merged
danielgarthur merged 1 commit intomasterfrom
arm64
Apr 18, 2025
Merged

Add macOS ARM64 build#1377
danielgarthur merged 1 commit intomasterfrom
arm64

Conversation

@basil
Copy link
Copy Markdown
Member

@basil basil commented Apr 18, 2025

Reverts cea1b32. Fixes #1371.

Testing done

With CSC_FOR_PULL_REQUEST temporarily set to true, observed the expected

  • falling back to ad-hoc signature for macOS application code signing
  • signing         file=dist/mac-arm64/Neanes.app platform=darwin type=distribution identityName=- identityHash=none provisioningProfile=none
  • skipped macOS notarization  reason=`notarize` options were unable to be generated

from electron-userland/electron-builder#9007. Downloaded the resulting .dmg file and installed to /Applications. Right-clicked and selected Open, saw "Neanes Not Opened: Apple could not verify Neanes is free of malware that may harm your Mac or compromise your privacy." (This is expected, and is better than the previous result of "damaged.") Went to Settings, Privacy & Security, saw "Neanes was blocked to protect your Mac," and clicked Open Anyway. Neanes launched and playback was fine.

@basil basil added the Component: Electron Issues related to Electron label Apr 18, 2025
@basil basil force-pushed the arm64 branch 2 times, most recently from e821363 to 200f68c Compare April 18, 2025 01:50
Comment thread .github/workflows/ci.yml
Comment on lines +45 to +50
- name: Publish
uses: actions/upload-artifact@v4
with:
name: Neanes-${{ matrix.os }}
path: dist/Neanes-*
retention-days: 3
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not strictly needed for this PR, but needed for me to be able to test the CI build and seems useful more generally. Signing will not take place without setting CSC_FOR_PULL_REQUEST=true, and I used that during testing but did not retain it in the final version of this PR because of scary-looking security warnings printed to the logs. CSC_FOR_PULL_REQUEST should not be necessary for the release pipeline.

Comment thread package.json
"@vue/eslint-config-typescript": "^14.5.0",
"electron": "^35.1.5",
"electron-builder": "^26.0.12",
"electron-builder": "^26.0.13",
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@basil basil requested a review from danielgarthur April 18, 2025 02:37
@basil basil marked this pull request as ready for review April 18, 2025 02:37
@basil basil mentioned this pull request Apr 18, 2025
3 tasks
@danielgarthur danielgarthur merged commit 1d59316 into master Apr 18, 2025
4 checks passed
@basil basil deleted the arm64 branch April 18, 2025 02:49
@basil basil added the Type: Feature New Feature label Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Electron Issues related to Electron Type: Feature New Feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Playback hiccups

2 participants