Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

control power and source_strength #961

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

aprilnovak
Copy link
Collaborator

No description provided.

Copy link
Contributor

@lewisgross1296 lewisgross1296 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is definitely a very quick change! Looking at the Controls System docs, it looks like their example stores a const real & in the header. Right now, we have

  /// Power by which to normalize the OpenMC results, for k-eigenvalue mode
  const Real * _power;

  /// Source strength by which to normalize the OpenMC results, for fixed source mode
  const Real * _source_strength;

in include/base/OpenMCProblemBase.h. My C++ is a little rusty, but is declaring them as pointers alright instead of as a reference?

@aprilnovak
Copy link
Collaborator Author

yep, you're totally right -- I was going too quickly! Do you want to give that a try to add?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants