-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
244: Fix GMD recordMode not working as expected #248
Conversation
8ce8db9
to
a1a00c8
Compare
Update ManifestHelper to use alternate version of getApplicationInfo
a1a00c8
to
9ac0bd6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like we can't build the Plugin
module with JDK 21 because of mismatched default versions.
Could we drive-by address this here since we're bumping Gradle in this PR? Something like this in Plugin/Gradle/build.gradle
should do it...
java {
toolchain {
languageVersion = JavaLanguageVersion.of(17)
}
}
Should I just update Bitrise to use java 21? |
@DanielJette That will still require migrating the Kotlin tasks to use |
…eJava' (21) and 'compileKotlin' (17)."
What does this change accomplish?
How have you achieved it?
Record mode in GMD tests were not working since the
recordMode
flag was not being passed from thetestify {}
closure to the testify library.The version of
getApplicationInfo()
added in API 33 was not returning the expected manifest data. Reverting to the original (since API 1) version ofgetApplicationInfo
works as expected.@matthew-shin-hs
Notice
Warning
This change must keep
main
in a shippable state; it may be shipped without further notice.