Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

244: Fix GMD recordMode not working as expected #248

Merged
merged 4 commits into from
Feb 19, 2025
Merged

Conversation

DanielJette
Copy link
Contributor

@DanielJette DanielJette commented Feb 17, 2025

What does this change accomplish?

How have you achieved it?

Record mode in GMD tests were not working since the recordMode flag was not being passed from the testify {} closure to the testify library.

The version of getApplicationInfo() added in API 33 was not returning the expected manifest data. Reverting to the original (since API 1) version of getApplicationInfo works as expected.

@matthew-shin-hs

Notice

Warning

This change must keep main in a shippable state; it may be shipped without further notice.

Copy link
Collaborator

@jaredh jaredh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we can't build the Plugin module with JDK 21 because of mismatched default versions.

Could we drive-by address this here since we're bumping Gradle in this PR? Something like this in Plugin/Gradle/build.gradle should do it...

java {
    toolchain {
        languageVersion = JavaLanguageVersion.of(17)
    }
}

@DanielJette
Copy link
Contributor Author

It looks like we can't build the Plugin module with JDK 21 because of mismatched default versions.

Could we drive-by address this here since we're bumping Gradle in this PR? Something like this in Plugin/Gradle/build.gradle should do it...

java {
    toolchain {
        languageVersion = JavaLanguageVersion.of(17)
    }
}

Should I just update Bitrise to use java 21?

@jaredh
Copy link
Collaborator

jaredh commented Feb 18, 2025

Should I just update Bitrise to use java 21?

@DanielJette That will still require migrating the Kotlin tasks to use 21 - currently they're set to 17. Off the cuff, not sure if there's any downstream impact to targeting a higher JVM but there's no harm continuing to target 17. The problem is some targets are currently unspecified so they default to using the current JDK version.

@DanielJette DanielJette merged commit 8e048a7 into main Feb 19, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Gradle 8.10.2 GMD recordMode not working as expected
3 participants