-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Plugin-Local with Composite Build #231
Conversation
The trick is to set |
1c724a3
to
8bfd9c3
Compare
8bfd9c3
to
d655231
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love seeing that JAR deleted finally. 😍
|
||
sourceCompatibility = JavaVersion.VERSION_17 | ||
gradlePlugin { | ||
automatedPublishing = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably a sign that we should move to letting the plugin generate the publications itself, but glad this is all it took.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely not. Never touching publishing again unless something is deprecated or broken 😆
I spent an embarrassing amount of time trying to get the built-in publishing to produce a properly signed plugin that was compatible with Maven Central. gradlePlugin
is designed to publish to https://plugins.gradle.org/
and the Maven Central support is confusing and seemingly impossible to configure properly.
What does this change accomplish?
Resolves #209
How have you achieved it?
Scope of Impact and Testing instructions
The samples and libraries should be unaffected from this change. API should be consistent with 3.1.0, but the local builds will now use Composite Builds instead of requiring a local copy of the plugin jar.
I have tested and published an alpha version of this to
3.2.0-alpha05
Notice
Warning
This change must keep
main
in a shippable state; it may be shipped without further notice.