-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fixes and performance improvements for the ParallelPixelProcessor #212
Conversation
✅ Success! - Legacy Sample screenshot test resultsView build for commit 91e3f6b |
✅ Success! - Flix Sample screenshot test resultsView build for commit 91e3f6b |
✅ Success! - Flix Library screenshot test resultsView build for commit 91e3f6b |
1b9f728
to
85e49ef
Compare
85e49ef
to
94a1257
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Code
✅ Tested
94a1257
to
1d5af08
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this last rebase has a legit test failure.
Yes, I noticed that. There's definitely a logical conflict between this PR and what was in the ScenarioRule changes. I'll address these failure and push up a fix. |
…d calculations inside the loop
6d15ec2
to
aa8221b
Compare
What does this change accomplish?
parallelThreads
extension property to the Gradle plugin. This allows for customization of the number of worker threads to be used by the ParallelProcessor. Set limits on the thread pool to a minimum of 1 and a maximum of 4.assertSame()
Scope of Impact and Testing instructions
Notice
Warning
This change must keep
main
in a shippable state; it may be shipped without further notice.