Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes and performance improvements for the ParallelPixelProcessor #212

Merged
merged 8 commits into from
Jun 3, 2024

Conversation

DanielJette
Copy link
Contributor

@DanielJette DanielJette commented May 27, 2024

What does this change accomplish?

  • Add parallelThreads extension property to the Gradle plugin. This allows for customization of the number of worker threads to be used by the ParallelProcessor. Set limits on the thread pool to a minimum of 1 and a maximum of 4.
  • Refactor the ParallelPixelProcessor and introduce a new configuration class to wrap the thread configuration variables and the CoroutineDispatcher configuration.
  • Several small improvements to the FuzzyCompare method to perform fewer allocations inside the analyze function
  • Upgrade UiAutomator dependency to 2.3.0 https://developer.android.com/jetpack/androidx/releases/test-uiautomator
  • Recycle the bitmaps in the finalize block of assertSame()
  • Add several new tests and enhancements to the existing ParallelProcessor tests
  • Upgrade the compile SDK for the samples to 34

Scope of Impact and Testing instructions

  • The existing tests should sufficiently verify that there are no regressions.

Notice

Warning

This change must keep main in a shippable state; it may be shipped without further notice.

@AndroidTestifyBot
Copy link
Contributor

AndroidTestifyBot commented May 27, 2024

✅ Success! - Legacy Sample screenshot test results

View build for commit 91e3f6b

@AndroidTestifyBot
Copy link
Contributor

AndroidTestifyBot commented May 27, 2024

✅ Success! - Flix Sample screenshot test results

View build for commit 91e3f6b

@AndroidTestifyBot
Copy link
Contributor

AndroidTestifyBot commented May 27, 2024

✅ Success! - Flix Library screenshot test results

View build for commit 91e3f6b

@DanielJette DanielJette changed the title Bug fixes and performance improvements for the FullscreenCaptureMethod extension Bug fixes and performance improvements for the ParallelPixelProcessor May 27, 2024
@DanielJette DanielJette marked this pull request as ready for review May 27, 2024 02:02
@DanielJette DanielJette requested a review from a team May 27, 2024 02:03
Copy link
Contributor

@AndroidTestifyBot AndroidTestifyBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Code
✅ Tested

Copy link
Collaborator

@jaredh jaredh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this last rebase has a legit test failure.

@djette-st
Copy link
Contributor

Looks like this last rebase has a legit test failure.

Yes, I noticed that. There's definitely a logical conflict between this PR and what was in the ScenarioRule changes. I'll address these failure and push up a fix.

@DanielJette DanielJette mentioned this pull request Jun 1, 2024
@DanielJette DanielJette requested a review from jaredh June 2, 2024 17:21
@DanielJette DanielJette merged commit 9c7e8b3 into main Jun 3, 2024
2 checks passed
@DanielJette DanielJette deleted the fullscreen-tweaks branch June 3, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants