Skip to content

Add DSMR5 option to protocol.#23

Merged
ndokter merged 1 commit into
ndokter:masterfrom
aequitas:dsmr5
May 12, 2017
Merged

Add DSMR5 option to protocol.#23
ndokter merged 1 commit into
ndokter:masterfrom
aequitas:dsmr5

Conversation

@aequitas
Copy link
Copy Markdown
Contributor

This will allow support for: home-assistant/core#7535

Currently i'm assuming V5 serial settings are equal to V4. I will ask users to test.

@codecov-io
Copy link
Copy Markdown

codecov-io commented May 12, 2017

Codecov Report

Merging #23 into master will decrease coverage by 0.69%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #23     +/-   ##
=========================================
- Coverage   70.33%   69.63%   -0.7%     
=========================================
  Files          12       12             
  Lines         300      303      +3     
  Branches       24       25      +1     
=========================================
  Hits          211      211             
- Misses         87       90      +3     
  Partials        2        2
Impacted Files Coverage Δ
dsmr_parser/clients/protocol.py 56.25% <0%> (-2.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de5c884...efc09df. Read the comment docs.

@ndokter ndokter merged commit 1dca6ab into ndokter:master May 12, 2017
@aequitas
Copy link
Copy Markdown
Contributor Author

aequitas commented May 12, 2017

@ndokter I've seen you have been working on automatic version detection. Nice. I have been pondering that feature for a while. I will keep an eye on it and add support for HA when it is released.

@ndokter
Copy link
Copy Markdown
Owner

ndokter commented May 12, 2017

Thank you for the pull request. Ive merged your changes and uploaded a new version to pypi.

The automatic detection is nice, but im not sure what kind of object it would return. Maybe not just a simple dict.

Currently not working on dsmr-parser so much :)

@aequitas aequitas deleted the dsmr5 branch May 12, 2017 20:37
@aequitas
Copy link
Copy Markdown
Contributor Author

Probably because it is already perfect ;) I'm waiting for some people with DSMR5 to confirm the changes work as expected, if not there might be another PR in a few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants