Use "grpc" (C-based implementation) instead of "@grpc/grpc-js" (pure …

…JavaScript implementation) due to issue/error under high load (See: grpc/grpc-node#1158)
ndidplatform · Mar 31, 2022 · ca32017 · ca32017
1 parent c25672c
commit ca32017
Show file tree

Hide file tree

Showing 8 changed files with 2,064 additions and 208 deletions.
diff --git a/main-server/package-lock.json b/main-server/package-lock.json
diff --git a/main-server/package.json b/main-server/package.json
@@ -16,7 +16,6 @@
   },
   "dependencies": {
     "@babel/runtime": "^7.17.7",
-    "@grpc/grpc-js": "^1.5.10",
     "@grpc/proto-loader": "^0.6.9",
     "ajv": "^8.10.0",
     "ajv-formats": "^2.1.1",
@@ -28,6 +27,7 @@
     "data-urls": "^3.0.1",
     "dotenv": "^16.0.0",
     "express": "^4.17.3",
+    "grpc": "^1.24.11",
     "ioredis": "^4.28.5",
     "mkdirp": "^1.0.4",
     "morgan": "^1.10.0",

diff --git a/main-server/src/master-worker-interface/client.js b/main-server/src/master-worker-interface/client.js
@@ -23,7 +23,7 @@
 import path from 'path';
 import EventEmitter from 'events';
 
-import * as grpc from '@grpc/grpc-js';
+import * as grpc from 'grpc';
 import * as protoLoader from '@grpc/proto-loader';
 
 import { ExponentialBackoff } from 'simple-backoff';
@@ -169,15 +169,9 @@ export async function initialize() {
       'grpc.keepalive_time_ms': config.grpcPingInterval,
       'grpc.keepalive_timeout_ms': config.grpcPingTimeout,
       'grpc.keepalive_permit_without_calls': 1,
-
-      // options for C-based version (not supported on pure JavaScript version)
-      // 'grpc.http2.max_pings_without_data': 0,
-      // 'grpc.http2.min_time_between_pings_ms': config.grpcPingInterval,
-
+      'grpc.http2.max_pings_without_data': 0,
+      'grpc.http2.min_time_between_pings_ms': config.grpcPingInterval,
       'grpc.max_receive_message_length': -1,
-
-      // option for pure JavaScript version
-      'grpc-node.max_session_memory': 100,
     }
   );
   await waitForReady(client);

diff --git a/main-server/src/master-worker-interface/server.js b/main-server/src/master-worker-interface/server.js
@@ -23,7 +23,7 @@
 import path from 'path';
 import EventEmitter from 'events';
 
-import * as grpc from '@grpc/grpc-js';
+import * as grpc from 'grpc';
 import * as protoLoader from '@grpc/proto-loader';
 
 import { getArgsProtobuf } from './message';
@@ -79,17 +79,11 @@ export async function initialize() {
     'grpc.keepalive_time_ms': config.grpcPingInterval,
     'grpc.keepalive_timeout_ms': config.grpcPingTimeout,
     'grpc.keepalive_permit_without_calls': 1,
-
-    // options for C-based version (not supported on pure JavaScript version)
-    // 'grpc.http2.max_pings_without_data': 0,
-    // 'grpc.http2.min_ping_interval_without_data_ms':
-    //   config.grpcExpectedClientPingInterval,
-    // 'grpc.http2.min_time_between_pings_ms': config.grpcPingInterval,
-
+    'grpc.http2.max_pings_without_data': 0,
+    'grpc.http2.min_ping_interval_without_data_ms':
+      config.grpcExpectedClientPingInterval,
+    'grpc.http2.min_time_between_pings_ms': config.grpcPingInterval,
     'grpc.max_receive_message_length': -1,
-
-    // option for pure JavaScript version
-    'grpc-node.max_session_memory': 100,
   });
   const MASTER_SERVER_ADDRESS = `0.0.0.0:${config.masterServerPort}`;
 
@@ -103,26 +97,18 @@ export async function initialize() {
     workerStoppingCall,
   });
 
-  const port = await new Promise((resolve, reject) => {
-    server.bindAsync(
-      MASTER_SERVER_ADDRESS,
-      config.grpcSsl
-        ? grpc.ServerCredentials.createSsl(grpcSslRootCert, [
-            {
-              cert_chain: grpcSslCert,
-              private_key: grpcSslKey,
-            },
-          ])
-        : grpc.ServerCredentials.createInsecure(),
-      (err, port) => {
-        if (err) {
-          reject(err);
-          return;
-        }
-        resolve(port);
-      }
-    );
-  });
+  const port = server.bind(
+    MASTER_SERVER_ADDRESS,
+    config.grpcSsl
+      ? grpc.ServerCredentials.createSsl(grpcSslRootCert, [
+          {
+            cert_chain: grpcSslCert,
+            private_key: grpcSslKey,
+          },
+        ])
+      : grpc.ServerCredentials.createInsecure()
+  );
+
   server.start();
 
   logger.info({

diff --git a/main-server/src/mq/grpc_client.js b/main-server/src/mq/grpc_client.js
@@ -23,7 +23,7 @@
 import path from 'path';
 import { EventEmitter } from 'events';
 
-import * as grpc from '@grpc/grpc-js';
+import * as grpc from 'grpc';
 import * as protoLoader from '@grpc/proto-loader';
 import { ExponentialBackoff } from 'simple-backoff';
 
@@ -160,13 +160,8 @@ export async function initialize({
       'grpc.keepalive_time_ms': config.grpcPingInterval,
       'grpc.keepalive_timeout_ms': config.grpcPingTimeout,
       'grpc.keepalive_permit_without_calls': 1,
-
-      // options for C-based version (not supported on pure JavaScript version)
-      // 'grpc.http2.max_pings_without_data': 0,
-      // 'grpc.http2.min_time_between_pings_ms': config.grpcPingInterval,
-
-      // option for pure JavaScript version
-      'grpc-node.max_session_memory': 100,
+      'grpc.http2.max_pings_without_data': 0,
+      'grpc.http2.min_time_between_pings_ms': config.grpcPingInterval,
     }
   );
   await waitForReady(client);