Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ordering of state objects reversed for complex module expressions #89

Open
jjg-123 opened this issue Dec 22, 2024 · 0 comments
Open

Ordering of state objects reversed for complex module expressions #89

jjg-123 opened this issue Dec 22, 2024 · 0 comments

Comments

@jjg-123
Copy link
Collaborator

jjg-123 commented Dec 22, 2024

In the ModuleExpression, the mechanism for resolving ambient variables was reversed, causing variables that were locally overridden to be ignored. This could not have been exposed without having a much more complex testing stack than in the unit tests, (thanks Robin!!) but a user did indeed get enough levels of scoping to trip this.

Solution is to swap two lines, and make sure the are loaded in the right order.

jjg-123 added a commit that referenced this issue Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant