perf: Use Python builtin RNG to generate Bernoulli samples #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nunezco2
approved these changes
Jul 25, 2022
AngelSaint
pushed a commit
to AngelSaint/COVID19-mesa
that referenced
this pull request
Nov 8, 2025
perf: Use Python builtin RNG to generate Bernoulli samples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For steps of 100, this improves the time for
CovidAgent.stepfrom 20 s to 8.9 s. Also, this makes it easy to use a batch of pre-generated uniform random numbers. As in, there could be a follow-up PR that further speeds upbernoulli_rvs.But upon benchmarking, the
bernoulli_rvsis no longer the most time-consuming part ofCovidAgent.step. It becomesCovidAgent.move. I measured the time forCovidAgent.move; most of it is due topoisson.rvs.