Skip to content

allow for import of commonjs modules #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 9, 2018
Merged

allow for import of commonjs modules #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af4f996
fix typo in error report
ncphillips Jan 9, 2018
d3f36c4
log out full error with link to github issues
ncphillips Jan 9, 2018
491db50
allow for the import of commonjs modules
ncphillips Jan 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/create-typescript-package/createTypescriptPackage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ const program = new commander.Command(packageJson.name)
)
console.log(
` ${chalk.cyan(
"https://github.com/facebookincubator/create-typescript-package/issues/new"
"https://github.com/ncphillips/create-typescript-package/issues/new"
)}`
)
console.log()
Expand Down
1 change: 1 addition & 0 deletions packages/type-scripts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
"chalk": "^2.3.0",
"react-dev-utils": "^4.2.1",
"rollup": "^0.53.3",
"rollup-plugin-commonjs": "^8.2.6",
"rollup-plugin-node-resolve": "^3.0.0",
"rollup-plugin-typescript2": "^0.9.0"
},
Expand Down
27 changes: 22 additions & 5 deletions packages/type-scripts/scripts/build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
#! /usr/bin/env node
const chalk = require("chalk")
const path = require("path")
const rollupTypescript = require("rollup-plugin-typescript2")
const rollup = require("rollup")
const resolve = require("rollup-plugin-node-resolve")
const commonJs = require("rollup-plugin-commonjs")

const PROJECT = "../../../"
const NODE_MODULES = "../../"
Expand All @@ -29,6 +31,9 @@ const inputOptions = {
moduleDirectory: path.resolve(__dirname, NODE_MODULES),
},
}),
commonJs({
sourceMap: true,
}),
],
}

Expand All @@ -48,8 +53,20 @@ async function build() {
await bundle.write(outputOptions)
}

try {
build()
} catch (e) {
console.error("Failed to build Typescript project", e)
}
build().catch(e => {
console.log(chalk.red("Build Failed"))
console.log()
console.log(
chalk.red(
"If you cannot figure out what's causing this failure please create a new issue in Github:"
)
)
console.log()
console.log(
`\t${chalk.cyan(
"https://github.com/ncphillips/create-typescript-package/issues/new"
)}`
)
console.log()
console.error(e)
})
30 changes: 29 additions & 1 deletion packages/type-scripts/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
# yarn lockfile v1


acorn@^5.2.1:
version "5.3.0"
resolved "https://registry.yarnpkg.com/acorn/-/acorn-5.3.0.tgz#7446d39459c54fb49a80e6ee6478149b940ec822"

[email protected], address@^1.0.1:
version "1.0.3"
resolved "https://registry.yarnpkg.com/address/-/address-1.0.3.tgz#b5f50631f8d6cec8bd20c963963afb55e06cbce9"
Expand Down Expand Up @@ -170,6 +174,10 @@ estree-walker@^0.3.0:
version "0.3.1"
resolved "https://registry.yarnpkg.com/estree-walker/-/estree-walker-0.3.1.tgz#e6b1a51cf7292524e7237c312e5fe6660c1ce1aa"

estree-walker@^0.5.0:
version "0.5.1"
resolved "https://registry.yarnpkg.com/estree-walker/-/estree-walker-0.5.1.tgz#64fc375053abc6f57d73e9bd2f004644ad3c5854"

esutils@^2.0.2:
version "2.0.2"
resolved "https://registry.yarnpkg.com/esutils/-/esutils-2.0.2.tgz#0abf4f1caa5bcb1f7a9d8acc6dea4faaa04bac9b"
Expand Down Expand Up @@ -479,6 +487,12 @@ lru-cache@^4.0.1:
pseudomap "^1.0.2"
yallist "^2.1.2"

magic-string@^0.22.4:
version "0.22.4"
resolved "https://registry.yarnpkg.com/magic-string/-/magic-string-0.22.4.tgz#31039b4e40366395618c1d6cf8193c53917475ff"
dependencies:
vlq "^0.2.1"

micromatch@^2.3.11:
version "2.3.11"
resolved "https://registry.yarnpkg.com/micromatch/-/micromatch-2.3.11.tgz#86677c97d1720b363431d04d0d15293bd38c1565"
Expand Down Expand Up @@ -656,7 +670,7 @@ [email protected]:
version "1.1.7"
resolved "https://registry.yarnpkg.com/resolve/-/resolve-1.1.7.tgz#203114d82ad2c5ed9e8e0411b3932875e889e97b"

resolve@^1.1.6, resolve@^1.5.0:
resolve@^1.1.6, resolve@^1.4.0, resolve@^1.5.0:
version "1.5.0"
resolved "https://registry.yarnpkg.com/resolve/-/resolve-1.5.0.tgz#1f09acce796c9a762579f31b2c1cc4c3cddf9f36"
dependencies:
Expand All @@ -669,6 +683,16 @@ restore-cursor@^2.0.0:
onetime "^2.0.0"
signal-exit "^3.0.2"

rollup-plugin-commonjs@^8.2.6:
version "8.2.6"
resolved "https://registry.yarnpkg.com/rollup-plugin-commonjs/-/rollup-plugin-commonjs-8.2.6.tgz#27e5b9069ff94005bb01e01bb46a1e4873784677"
dependencies:
acorn "^5.2.1"
estree-walker "^0.5.0"
magic-string "^0.22.4"
resolve "^1.4.0"
rollup-pluginutils "^2.0.1"

rollup-plugin-node-resolve@^3.0.0:
version "3.0.0"
resolved "https://registry.yarnpkg.com/rollup-plugin-node-resolve/-/rollup-plugin-node-resolve-3.0.0.tgz#8b897c4c3030d5001277b0514b25d2ca09683ee0"
Expand Down Expand Up @@ -813,6 +837,10 @@ url-parse@^1.1.8:
querystringify "~1.0.0"
requires-port "~1.0.0"

vlq@^0.2.1:
version "0.2.3"
resolved "https://registry.yarnpkg.com/vlq/-/vlq-0.2.3.tgz#8f3e4328cf63b1540c0d67e1b2778386f8975b26"

websocket-driver@>=0.5.1:
version "0.7.0"
resolved "https://registry.yarnpkg.com/websocket-driver/-/websocket-driver-0.7.0.tgz#0caf9d2d755d93aee049d4bdd0d3fe2cca2a24eb"
Expand Down