Skip to content

Commit

Permalink
fix: fix cell widths overridden by readjusted smaller breakpoints in …
Browse files Browse the repository at this point in the history
…XY Grid foundation#10468

With margin gutters, a cell width is defined with its gutter. This is why we have to readjust all sizes and not only `.cell` when applying the new gutter in a bigger breakpoint. This must include all sizes for smaller breakpoints too.

Before this commit there was an optimization that prevent gutters for smaller breakpoints without a new gutter defined to be regenerated. This can seems logical since no gutter was generated for this breakpoint so there is nothing to readjust.

However, because the gutter is defined _with the width/height_, the readjusted width/height of readjusted gutters (with a custom gutter) overrides the width/height of bigger non-readjusted (without a custom gutter) breakpoint.

Changes:
* Readjust gutters for all breakpoints even without new gutter defined
* Add explainaitions

Closes foundation#10468
  • Loading branch information
ncoden committed Apr 1, 2018
1 parent 78bda61 commit 2b5aaa7
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions scss/xy-grid/_classes.scss
Original file line number Diff line number Diff line change
Expand Up @@ -146,12 +146,12 @@
@include -zf-each-breakpoint() {

// This is purely for responsive gutters - the margin grid has to go back and adjust widths (or heights)
// for prior breakpoints based on the responsive gutter.
// for all prior breakpoints.
// As their gutter is defined with their width/height, even breakpoint without a new margin must be
// generated to not having their width/height overrided by re-adjusted smaller breakpoints.
@if(type-of($grid-margin-gutters) == 'map' and map-has-key($grid-margin-gutters, $-zf-size)) {
@each $bp in -zf-breakpoints-less-than($-zf-size) {
@if(map-has-key($grid-margin-gutters, $bp)) {
@include -xy-breakpoint-cell-classes($bp, $-zf-size, $vertical);
}
@include -xy-breakpoint-cell-classes($bp, $-zf-size, $vertical);
}
}

Expand Down

0 comments on commit 2b5aaa7

Please sign in to comment.