Skip to content

consistent gas estimation #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ncitron merged 6 commits into from
Nov 8, 2021
Merged

consistent gas estimation #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2ce9250
add seth estimate-raw
ncitron Nov 8, 2021
d06f6ba
use seth estimate for mktx estimation
ncitron Nov 8, 2021
07483f9
add gas estimation for rpc sends
ncitron Nov 8, 2021
8d5b6fe
fix null data
ncitron Nov 8, 2021
5a7e024
fix null data
ncitron Nov 8, 2021
7c8b24e
fix null data
ncitron Nov 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/seth/libexec/seth/seth-estimate
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
### or: seth estimate [<options>] <receiver> <data>
### or: seth estimate [<options>] --create <code> <sig> [<args>]
### or: seth estimate [<options>] --create <code> <data>
### or: seth estimate [<options>] --create <data>
###
### Perform a local call to <receiver> and return the gas usage.
###
Expand All @@ -15,7 +16,7 @@
### With `-F <sender>', simulate calling <receiver> from <sender>
### With `-V <value>', simulate transferring <value> to <receiver>.
set -e
[[ $2 ]] || seth --fail-usage "$0"
[[ $1 ]] || seth --fail-usage "$0"

if [[ $SETH_CREATE ]]; then
DATA=$(seth --to-hexdata "$1")
Expand Down
12 changes: 5 additions & 7 deletions src/seth/libexec/seth/seth-mktx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,11 @@ if [[ -z "$SETH_CREATE" ]]; then
fi

if [[ -z "$ETH_GAS" ]]; then
jshon+=(-n {})
[[ $TO ]] && jshon+=(-s "$TO" -i to)
jshon+=(-s "$data" -i data)
# shellcheck disable=SC2207
jshon+=($(SETH_PARAMS_NO_GAS=1 seth --send-params))
jshon+=(-i append)
ETH_GAS=$(seth rpc eth_estimateGas -- "${jshon[@]}")
if [[ $SETH_CREATE ]]; then
ETH_GAS=$(seth estimate --create $data)
else
ETH_GAS=$(seth estimate $TO $data)
fi
fi

args=(
Expand Down
9 changes: 9 additions & 0 deletions src/seth/libexec/seth/seth-send
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,18 @@ else
fi
fi

if [[ -z "$ETH_GAS" ]]; then
if [[ $SETH_CREATE ]]; then
ETH_GAS=$(seth estimate --create $DATA)
else
ETH_GAS=$(seth estimate $TO ${DATA:-0x})
fi
fi

jshon+=(-n {})
[[ $TO ]] && jshon+=(-s "$TO" -i to)
[[ $DATA ]] && jshon+=(-s "$DATA" -i data)
[[ $ETH_GAS ]] && jshon+=(-s "$ETH_GAS" -i gas)
# shellcheck disable=SC2207
jshon+=($(seth --send-params))
jshon+=(-i append)
Expand Down