Added support for white-spaces in target #8
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It might have something to do with the fact that I run on WSL2 (or me being stupid). However, if the target directory for searching contains whitespace (no matter if they are escaped using
"/some path/dir"
or/some \path/dir"
it causes errors.Examples:
Without this patch:
Input:
/c/Users/User/source/php-malware-finder/php-malware-finder/phpmalwarefinder -c "/c/Users/User/source/php-malware-finder/php-malware-finder/php.yar" -t 4 ~/white\ space\ test/php_malware_finder/test_1/
Output:
error: could not open file: /home/alex/white
Input:
/c/Users/User/source/php-malware-finder/php-malware-finder/phpmalwarefinder -c "/c/Users/User/source/php-malware-finder/php-malware-finder/php.yar" -t 4 "white space test/php_malware_finder/test_1"
Output:
error: could not open file: white
With this patch:
Input:
/c/Users/User/source/php-malware-finder/php-malware-finder/phpmalwarefinder -c "/c/Users/User/source/php-malware-finder/php-malware-finder/php.yar" -t 4 ~/white\ space\ test/php_malware_finder/test_1/
Output (as expected):
DodgyPhp /home/alex/white space test/php_malware_finder/test_1/aboba.php
ObfuscatedPhp /home/alex/white space test/php_malware_finder/test_1/SendMonthlyTaskListCompletionReminder.php
Input:
/c/Users/User/source/php-malware-finder/php-malware-finder/phpmalwarefinder -c "/c/Users/User/source/php-malware-finder/php-malware-finder/php.yar" -t 4 "white space test/php_malware_finder/test_1"
Output (as expected):
DodgyPhp /home/alex/white space test/php_malware_finder/test_1/aboba.php
ObfuscatedPhp /home/alex/white space test/php_malware_finder/test_1/SendMonthlyTaskListCompletionReminder.php