Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to get jodel key and version from environment variables. #70

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

wetterfroschdus
Copy link

This allows people to keep using jodel_api without having to wait for an update.
I also added a version check, so jodel_api will prefer using the newer version over older versions. This way, people don't have to worry about having old keys in their environment variables.

Oh and I also added the newest Key and Version.

@codecov-io
Copy link

codecov-io commented Apr 14, 2018

Codecov Report

Merging #70 into master will decrease coverage by 4.68%.
The diff coverage is 35.71%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #70      +/-   ##
=======================================
- Coverage   94.68%   90%   -4.69%     
=======================================
  Files           6     6              
  Lines         508   520      +12     
=======================================
- Hits          481   468      -13     
- Misses         27    52      +25
Impacted Files Coverage Δ
src/jodel_api/jodel_api.py 84.68% <35.71%> (-6.8%) ⬇️
src/jodel_api/gcmhack.py 87.09% <0%> (-6.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca29453...fc9f5b7. Read the comment docs.

@nknappe
Copy link

nknappe commented Apr 25, 2018

Hello,
Unfortunately, the adjustment does not work.
With 4.84.1 you get the error 477 again.

@wetterfroschdus
Copy link
Author

Mhm works for me, can you walk me through the steps you took?

@wetterfroschdus
Copy link
Author

Also, the checks aren't working anymore, because Jodel seems to return empty objects for unverified accounts now.
So even for read-only access, you have to verify the account now.

@Daedra223
Copy link

@wetterfroschdus do you know how it is possible to verify the account? Using the methods mentioned here doesnt work ...

@hedgeback
Copy link

Hello @wetterfroschdus

I am having the same issue with that 477 Error. The question might be getting old. I updated the jodel_api to 1.2.12 with all the changes to the version and secrets. However, I just found out the newest version of Jodel is already version 4.92.2. Do you have any idea how I might get in possession of such?
I would appreciate any help.
Thanks already.

@wetterfroschdus
Copy link
Author

Try this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants