-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extracting and abstracting to enable use with Vela #4
Comments
Reading more, I think we might be able to use a lot of the plugin as-is, but need to be able to send in some different envvars and set the GitHub host, e.g.
and
and such would need to use an overrideable GitHub API hostname. |
colindean
added a commit
to colindean/diff-poetry-lock
that referenced
this issue
Oct 16, 2023
This won't be used on public GitHub Actions, but could be used outside of GHA. Work toward nborrmann#4
nborrmann
pushed a commit
that referenced
this issue
Oct 18, 2023
This won't be used on public GitHub Actions, but could be used outside of GHA. Work toward #4
colindean
added a commit
to colindean/diff-poetry-lock
that referenced
this issue
Oct 30, 2023
Also genericize the description for nborrmann#4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
My org uses Vela CI for CI/CD pipelines. I'd love to be able to use this tool with Vela, but it seems pretty tightly coupled to GitHub Actions at the moment because spots like
diff-poetry-lock/diff_poetry_lock/run_poetry.py
Line 115 in ee9be76
I don't know what my bandwidth will be to undertake this myself, but minimally, having a code path that would enable comparing two
poetry.lock
files without using the GitHub API would accomplish the task enough for me to wire it up as a pattern for Vela and then advance to building a Vela plugin around it.What do you think?
The text was updated successfully, but these errors were encountered: