Merge pull request #58 from nexxome/2.0

Added requestedAuthnContextComparison to security configuration
nbgrp · Sep 1, 2024 · d2feeb7 · d2feeb7
2 parents 8f6d83f + fd59708
commit d2feeb7
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 0 deletions.
diff --git a/README.md b/README.md
@@ -103,6 +103,7 @@ nbgrp_onelogin_saml:
                 wantNameId: false
                 wantNameIdEncrypted: false
                 requestedAuthnContext: true
+                requestedAuthnContextComparison: 'exact'
                 wantXMLValidation: false
                 relaxDestinationValidation: false
                 destinationStrictlyMatches: true

diff --git a/src/DependencyInjection/Configuration.php b/src/DependencyInjection/Configuration.php
@@ -178,6 +178,14 @@ public function getConfigTreeBuilder(): TreeBuilder
                                             ->thenInvalid('invalid value.')
                                         ->end()
                                     ->end()
+                                    ->enumNode('requestedAuthnContextComparison')
+                                        ->values([
+                                            'exact',
+                                            'minimum',
+                                            'maximum',
+                                            'better',
+                                        ])
+                                    ->end()
                                     ->booleanNode('wantXMLValidation')->end()
                                     ->booleanNode('relaxDestinationValidation')->end()
                                     ->booleanNode('destinationStrictlyMatches')->end()

diff --git a/tests/DependencyInjection/ConfigurationTest.php b/tests/DependencyInjection/ConfigurationTest.php
@@ -118,6 +118,7 @@ public static function provideValidConfigCases(): iterable
                             'wantNameId' => false,
                             'wantNameIdEncrypted' => false,
                             'requestedAuthnContext' => false,
+                            'requestedAuthnContextComparison' => 'exact',
                             'wantXMLValidation' => false,
                             'relaxDestinationValidation' => false,
                             'destinationStrictlyMatches' => false,
@@ -234,6 +235,7 @@ public static function provideValidConfigCases(): iterable
                             'wantNameId' => false,
                             'wantNameIdEncrypted' => false,
                             'requestedAuthnContext' => false,
+                            'requestedAuthnContextComparison' => 'exact',
                             'wantXMLValidation' => false,
                             'relaxDestinationValidation' => false,
                             'destinationStrictlyMatches' => false,