issequence check for fill_color. wireservice#26

nbedi · Jun 10, 2016 · 933386f · 933386f
1 parent d268298
commit 933386f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/leather/shapes/grouped_bars.py b/leather/shapes/grouped_bars.py
@@ -19,6 +19,9 @@ class GroupedBars(CategoryShape):
         greater than or equal to the number of values in any category.
     """
     def __init__(self, fill_color=None):
+        if fill_color and not issequence(fill_color):
+            raise ValueError('Fill color must be a sequence of strings.')
+
         self._fill_color = fill_color
         self._legend_dimension = Y
 

diff --git a/tests/test_shapes.py b/tests/test_shapes.py
@@ -201,6 +201,9 @@ def test_invalid_fill_color(self):
         with self.assertRaises(ValueError):
             group = self.shape.to_svg(200, 100, self.linear, self.ordinal, series, ['one', 'two'])
 
+        with self.assertRaises(ValueError):
+            shape = leather.GroupedBars('red')
+
     def test_nulls(self):
         series = leather.CategorySeries([
             (0, 'foo', 'first'),