standardize and improve resource and adapter modules #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pehbehbeh
commented
Nov 14, 2024
pehbehbeh
changed the title
Flo0807
approved these changes
Jan 24, 2025
Flo0807
reviewed
Jan 24, 2025
| @@ -328,9 +319,6 @@ defmodule Backpex.LiveResource do | |||
| @impl Backpex.LiveResource | |||
| def search_placeholder, do: Backpex.translate("Search") | |||
|
|
|||
| @impl Backpex.LiveResource | |||
| def item_query(query, _live_action, _assigns), do: query | |||
There was a problem hiding this comment.
This will no longer add fallback (cover all) item_query/3 functions to your LiveResources. I added a hint to the v0.11 upgrade guide that you have to cover all cases with item_query/3. We had this error in our demo, too. The User edit, show and new view crashed because of this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backpex.Resource(parameters and result tuples)Backpex.Adapter(parameters incl. typespecs)get!/1for now) inBackpex.Resourceinstead of specific adapters