Skip to content

Legg til personer i kafkakø #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 27, 2020
Merged

Legg til personer i kafkakø #300

merged 3 commits into from
Oct 27, 2020

Conversation

@ingvildstoen
Copy link
Contributor

@ingvildstoen ingvildstoen commented Oct 26, 2020

No description provided.

@ingvildstoen ingvildstoen force-pushed the legge-person-pa-kafka branch from 7b5fc79 to ef7b867 Compare October 26, 2020 08:44
@ingvildstoen ingvildstoen force-pushed the legge-person-pa-kafka branch from ef7b867 to a6dee1c Compare October 26, 2020 09:06
@ingvildstoen ingvildstoen force-pushed the legge-person-pa-kafka branch from a6dee1c to a5eeaa5 Compare October 26, 2020 09:16
@ingvildstoen ingvildstoen force-pushed the legge-person-pa-kafka branch 2 times, most recently from 9b80e58 to 62a2fdf Compare October 26, 2020 09:29
@nais-deploy nais-deploy bot temporarily deployed to dev-fss:dolly October 26, 2020 09:32 Inactive
@ingvildstoen ingvildstoen force-pushed the legge-person-pa-kafka branch from 62a2fdf to c821672 Compare October 26, 2020 09:45
@nais-deploy nais-deploy bot temporarily deployed to dev-fss:dolly October 26, 2020 09:49 Inactive
@ingvildstoen ingvildstoen force-pushed the legge-person-pa-kafka branch from c821672 to 13f961a Compare October 26, 2020 09:57
@nais-deploy nais-deploy bot temporarily deployed to dev-fss:dolly October 26, 2020 10:00 Inactive
@ingvildstoen ingvildstoen force-pushed the legge-person-pa-kafka branch 2 times, most recently from f3865ab to 7ee1dca Compare October 26, 2020 10:07
@nais-deploy nais-deploy bot temporarily deployed to dev-fss:dolly October 26, 2020 10:09 Inactive
@ingvildstoen ingvildstoen force-pushed the legge-person-pa-kafka branch from 7ee1dca to 3264daf Compare October 26, 2020 10:20
@nais-deploy nais-deploy bot temporarily deployed to dev-fss:dolly October 26, 2020 10:22 Inactive
@ingvildstoen ingvildstoen force-pushed the legge-person-pa-kafka branch from 3264daf to c5d3ef4 Compare October 26, 2020 11:32
@nais-deploy nais-deploy bot temporarily deployed to dev-fss:dolly October 26, 2020 13:04 Inactive
@ingvildstoen ingvildstoen force-pushed the legge-person-pa-kafka branch from c5d3ef4 to 6884e79 Compare October 27, 2020 07:56
@nais-deploy nais-deploy bot temporarily deployed to dev-fss:dolly October 27, 2020 07:58 Inactive
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 27, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
28.1% 28.1% Duplication

ingvildstoen
ingvildstoen commented Oct 27, 2020
View reviewed changes
...on/src/main/java/no/nav/registre/testnorge/originalpopulasjon/service/PopulasjonService.java
public class PopulasjonService {

private static final Set<String> TAGS = Set.of("Mini-Norge");
private static final Set<String> TAGS = Set.of("MINI_NORGE");
Copy link
Contributor Author

@ingvildstoen ingvildstoen Oct 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Foreløpig fiks før enum er på plass. Hvis vi lager en enum av tags, har vi både en enum og en database som holder oversikt. Smør på flesk?

Copy link
Contributor

@langvatn langvatn Oct 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kansjke vi får se

ingvildstoen
ingvildstoen commented Oct 27, 2020
View reviewed changes
apps/mn-original-populasjon/src/main/resources/application.yml
kafka:
bootstrapservers: b27apvl00045.preprod.local:8443,b27apvl00046.preprod.local:8443,b27apvl00047.preprod.local:8443
schemaregistryservers: http://kafka-schema-registry.tpa.svc.nais.local:8081
groupid: testnorge-hendelse-api-v1 #HVA GJØR VI MED DENNE?
Copy link
Contributor Author

@ingvildstoen ingvildstoen Oct 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hva skal group-id være her?

Copy link
Contributor

@langvatn langvatn Oct 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Den iden skal du ikke trenge med mindre du motar noe fra kjøen. Tror jeg

stigus
stigus approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@stigus stigus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kult, ser veldig bra ut 😄
Har dessverre dårlig med innspill til kommentarene 😅

langvatn
langvatn approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@langvatn langvatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supert, da fungerer køen på andre siden?

apps/mn-original-populasjon/src/main/resources/application.yml
kafka:
bootstrapservers: b27apvl00045.preprod.local:8443,b27apvl00046.preprod.local:8443,b27apvl00047.preprod.local:8443
schemaregistryservers: http://kafka-schema-registry.tpa.svc.nais.local:8081
groupid: testnorge-hendelse-api-v1 #HVA GJØR VI MED DENNE?
Copy link
Contributor

@langvatn langvatn Oct 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Den iden skal du ikke trenge med mindre du motar noe fra kjøen. Tror jeg

...on/src/main/java/no/nav/registre/testnorge/originalpopulasjon/service/PopulasjonService.java
public class PopulasjonService {

private static final Set<String> TAGS = Set.of("Mini-Norge");
private static final Set<String> TAGS = Set.of("MINI_NORGE");
Copy link
Contributor

@langvatn langvatn Oct 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kansjke vi får se

@ingvildstoen
Copy link
Contributor Author

ingvildstoen commented Oct 27, 2020

Supert, da fungerer køen på andre siden?

Bare send til kø som fungerer foreløpig. Fiks av mottak kommer i en egen 😄 Prøver å holde brancher og PRer så små som mulig.

@nais-deploy nais-deploy bot temporarily deployed to dev-fss:t2 October 27, 2020 10:33 Inactive
@nais-deploy nais-deploy bot temporarily deployed to dev-fss:dolly October 27, 2020 10:33 Inactive
@nais-deploy nais-deploy bot temporarily deployed to dev-fss:dolly October 27, 2020 10:33 Inactive
@nais-deploy nais-deploy bot temporarily deployed to dev-fss:dolly October 27, 2020 10:33 Inactive
@nais-deploy nais-deploy bot temporarily deployed to dev-fss:dolly October 27, 2020 10:33 Inactive
@nais-deploy nais-deploy bot temporarily deployed to dev-fss:t2 October 27, 2020 10:34 Inactive
@nais-deploy nais-deploy bot temporarily deployed to dev-fss:u2 October 27, 2020 10:34 Inactive
@nais-deploy nais-deploy bot temporarily deployed to dev-fss:t2 October 27, 2020 10:34 Inactive
@nais-deploy nais-deploy bot temporarily deployed to dev-fss:t6 October 27, 2020 10:34 Inactive
@ingvildstoen ingvildstoen merged commit c6561a9 into master Oct 27, 2020
@ingvildstoen ingvildstoen deleted the legge-person-pa-kafka branch October 27, 2020 14:17
@betsytraran betsytraran mentioned this pull request Oct 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stigus stigus stigus approved these changes

+1 more reviewer

@langvatn langvatn langvatn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ingvildstoen @langvatn @stigus