fix: panel flashes when using virtual option in react #916
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#915
Details
After the
display: none
style is applied to hidden Panel, there appears to be a flash before the correct transform is applied.applyTransform
does not work whenrenderer.rendering
is active.In the ReactRenderer, I modified the execution order as follows so that
applyTransform
is applied together with Panel addition/removal:The key change is that
this._rendering = true;
has been moved belowupdateRenderingPanels
.By implementing the modification above, the issue is resolved without needing to call
applyTransform
inbeforeRender
.renderPanels
is responsible for adding or removing Panels in the virtual area.updateRenderingPanels
callscamera.updateOffset();
.updateOffset
callsapplyTransform
, delaying the timing of settingrenderer.rendering
totrue
ensures that the translation values are correctly applied in accordance with the state where Panels are added/removed inrenderPanels
.