Fix deprecated findDOMNode usage in React 19

[jtwite]

Update the library to remove the use of deprecated findDOMNode and replace it with a ref-based approach.

• NonStrictPanel.tsx

  • Replace findDOMNode with React.createRef to access the DOM element.
  • Update the nativeElement getter to return the current ref.
  • Modify the render method to clone the element with the ref.

• ReactElementProvider.ts

  • Update the constructor to accept a ref instead of a StrictPanel or NonStrictPanel.
  • Update the element getter to return the current ref.
  • Modify the show and hide methods to use the ref.

• Flicking.tsx

  • Remove the useFindDOMNode prop and use a ref-based approach.
  • Update the _createPanelRefs method to use React.createRef.
  • Update the _getPanels method to use the new ref-based approach.

• ReactRenderer.ts

  • Update the _collectPanels method to use the new ref-based approach.
  • Update the _createPanel method to use the new ref-based approach.

• package-lock.json

  • Update the version to 4.12.0-snapshot.

[CLAassistant]

All committers have signed the CLA.

[malangfox]

Hello @jtwite. Thank you for your contribution.
Could you restore package.json and gitignore before merging it into our main branch?

[jtwite]

Definitely!

…

On Tue, Feb 18, 2025 at 12:16 AM malangfox ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In package.json <#909 (comment)>: > @@ -47,7 +47,7 @@ }, "repository": { "type": "git", - "url": "https://github.com/naver/egjs-flicking" + "url": "https://github.com/jtwite/egjs-flicking" Hello @jtwite <https://github.com/jtwite>. Thank you for your contribution. Could you restore package.json and gitignore before merging it into our main branch? — Reply to this email directly, view it on GitHub <#909 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADHYXVKYA3KSTVHF6BVBJDL2QLF3FAVCNFSM6AAAAABWO7PMHSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMMBXHE3TEMRQHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[malangfox]

createRef was added in later versions of React 16.
As long as we maintain support for early versions of React 16, we can't use createRef for this issue.

We are still looking into other ways to resolve this issue, so feel free to give us your insight here.

[InJaEE]

createRef was added in later versions of React 16. As long as we maintain support for early versions of React 16, we can't use createRef for this issue.

We are still looking into other ways to resolve this issue, so feel free to give us your insight here.

@malangfox
Hello. I found that createRef is already being used in Flicking.tsx and StrictPanel.tsx. Could this be unrelated to React 16 compatibility?

[malangfox]

@InJaEE
Thank you for checking our implementation that is something I missed. I think this PR won't cause any react version issues.
Since we have confirmed that createRef already exists in our implementation, there should be no problem with this fix.

@jtwite
Could you modify package.json and gitignore to match our main branch before merging?

[cs09g]

@jtwite Please update PR to get merged 😊

[malangfox]

Can you also branch if externalComponent is HTMLDivElement which does not use nativeElement?

[malangfox]

Since there were no additional changes, We will apply the changes you left in PR #931.