Add rubocop-rspec_rails gem and fix RSpec lint violations#29
Conversation
|
For this work, I initially set out to add a RuboCop Cop to enforce the use of |
doshitan
left a comment
There was a problem hiding this comment.
Seems fine to me if we only enable the "safe"/default cops and any of the non-default ones we want explicitly. And this can be added to https://github.com/navapbc/template-application-rails.
reporting-app/spec/controllers/staff/certification_batch_uploads_controller_spec.rb
Show resolved
Hide resolved
4e09d2a to
b2d84f0
Compare
|
Thanks for the review, @doshitan! I've move part of this work over to the rails template navapbc/template-application-rails#137. I've also updated to disable the |
969d37d to
9769f57
Compare
- Add rubocop-rspec_rails gem and configure in .rubocop.yml - Enable RSpecRails cops for HTTP status and validation matchers - Update HTTP status codes from :unprocessable_entity to :unprocessable_content - Replace numeric status checks (422) with semantic matcher have_http_status - Replace be_invalid with not_to be_valid for better RSpec idioms
9769f57 to
47293ac
Compare
Changes
Preview environment for reporting-app
♻️ Environment destroyed ♻️