Skip to content

Commit

Permalink
Enabling all disabled tests (Azure#337)
Browse files Browse the repository at this point in the history
* Use core version 1.2.0-beta.1 to resolve the tests issue

* remove comments
  • Loading branch information
rabee333 authored and navalev committed Dec 11, 2019
1 parent 0e24dc5 commit f85e4aa
Show file tree
Hide file tree
Showing 7 changed files with 2 additions and 27 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
import com.azure.search.test.environment.models.LoudHotel;
import io.netty.handler.codec.http.HttpResponseStatus;
import org.junit.Assert;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;

import java.text.DateFormat;
Expand Down Expand Up @@ -302,7 +301,6 @@ public void canUseIndexWithReservedName() {
Assert.assertNotNull(actual);
}

@Disabled
@Test
public void canRoundtripBoundaryValues() throws ParseException {
createHotelIndex();
Expand Down Expand Up @@ -358,7 +356,6 @@ public void dynamicDocumentDateTimesRoundTripAsUtc() {
Assert.assertEquals(utcTimeMinusEight.withOffsetSameInstant(ZoneOffset.UTC), ((OffsetDateTime) actualBook2.get("PublishDate")).withOffsetSameInstant(ZoneOffset.UTC));
}

@Disabled
@Test
public void staticallyTypedDateTimesRoundTripAsUtc() {
setupIndexFromJsonFile(BOOKS_INDEX_JSON);
Expand Down Expand Up @@ -389,7 +386,6 @@ public void staticallyTypedDateTimesRoundTripAsUtc() {
Assert.assertEquals(books.get(1).publishDate().withOffsetSameInstant(ZoneOffset.UTC), convertToType(actualBook2, Book.class).publishDate().withOffsetSameInstant(ZoneOffset.UTC));
}

@Disabled
@Test
public void canMergeStaticallyTypedDocuments() throws ParseException {
createHotelIndex();
Expand Down Expand Up @@ -523,8 +519,6 @@ public void mergeDocumentWithoutExistingKeyThrowsIndexingException() throws Pars
}
}


@Disabled
@Test
public void canSetExplicitNullsInStaticallyTypedDocument() throws ParseException {
createHotelIndex();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
import com.azure.search.test.environment.models.HotelRoom;
import com.azure.search.test.environment.models.ModelWithPrimitiveCollections;
import org.junit.Assert;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
import reactor.core.publisher.Mono;
import reactor.test.StepVerifier;
Expand All @@ -29,7 +28,6 @@
public class LookupAsyncTests extends LookupTestBase {
private SearchIndexAsyncClient client;

@Disabled
@Test
public void canGetStaticallyTypedDocument() throws ParseException {
createHotelIndex();
Expand Down Expand Up @@ -72,7 +70,6 @@ public void canGetStaticallyTypedDocumentWithPascalCaseFields() {
.verifyComplete();
}

@Disabled
@Test
public void canRoundtripStaticallyTypedPrimitiveCollections() {
setupIndexFromJsonFile(MODEL_WITH_DATA_TYPES_INDEX_JSON);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
import com.azure.search.test.environment.models.HotelRoom;
import com.azure.search.test.environment.models.ModelWithPrimitiveCollections;
import org.junit.Assert;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;

import java.text.ParseException;
import java.time.OffsetDateTime;
import java.util.Arrays;
Expand All @@ -25,7 +25,6 @@
public class LookupSyncTests extends LookupTestBase {
private SearchIndexClient client;

@Disabled
@Test
public void canGetStaticallyTypedDocument() throws ParseException {
createHotelIndex();
Expand Down Expand Up @@ -65,7 +64,6 @@ public void canGetStaticallyTypedDocumentWithPascalCaseFields() {
assertReflectionEquals(expected, actual, IGNORE_DEFAULTS);
}

@Disabled
@Test
public void canRoundtripStaticallyTypedPrimitiveCollections() {
setupIndexFromJsonFile(MODEL_WITH_DATA_TYPES_INDEX_JSON);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
import com.azure.search.test.environment.models.Hotel;
import com.azure.search.test.environment.models.NonNullableModel;
import org.junit.Assert;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
import reactor.core.publisher.Flux;
import reactor.test.StepVerifier;
Expand Down Expand Up @@ -391,7 +390,6 @@ public void canSearchDynamicDocuments() throws IOException {
Assert.assertTrue(compareResults(actualResults, hotels));
}

@Disabled
@Test
public void canSearchStaticallyTypedDocuments() throws IOException {
createHotelIndex();
Expand Down Expand Up @@ -433,7 +431,6 @@ public void canSearchStaticallyTypedDocuments() throws IOException {
assertReflectionEquals(hotelsList, actualResults, IGNORE_DEFAULTS);
}

@Disabled
@Test
public void canRoundTripNonNullableValueTypes() throws Exception {
setupIndexFromJsonFile(NON_NULLABLE_INDEX_JSON);
Expand Down Expand Up @@ -463,7 +460,6 @@ public void canRoundTripNonNullableValueTypes() throws Exception {
}).verifyComplete();
}

@Disabled
@Test
public void canSearchWithDateInStaticModel() throws ParseException, IOException {
createHotelIndex();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
import com.azure.search.test.environment.models.Hotel;
import com.azure.search.test.environment.models.NonNullableModel;
import org.junit.Assert;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;

import java.io.IOException;
Expand Down Expand Up @@ -156,7 +155,6 @@ public void canContinueSearchWithTop() {
Assert.assertNull(secondPage.getContinuationToken());
}

@Disabled
@Test
public void canSearchStaticallyTypedDocuments() throws IOException {
createHotelIndex();
Expand Down Expand Up @@ -200,7 +198,6 @@ public void canSearchStaticallyTypedDocuments() throws IOException {
assertReflectionEquals(hotelsList, actualResults, IGNORE_DEFAULTS);
}

@Disabled
@Test
public void canRoundTripNonNullableValueTypes() throws Exception {
setupIndexFromJsonFile(NON_NULLABLE_INDEX_JSON);
Expand Down Expand Up @@ -233,7 +230,6 @@ public void canRoundTripNonNullableValueTypes() throws Exception {
assertReflectionEquals(doc2, convertToType(result.getItems().get(1).getDocument(), NonNullableModel.class), IGNORE_DEFAULTS);
}

@Disabled
@Test
public void canSearchWithDateInStaticModel() throws ParseException, IOException {
createHotelIndex();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
import com.azure.search.test.environment.models.Book;
import io.netty.handler.codec.http.HttpResponseStatus;
import org.junit.Assert;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
import reactor.test.StepVerifier;

Expand Down Expand Up @@ -97,7 +96,6 @@ public void canGetFuzzySuggestions() throws IOException {
.verifyComplete();
}

@Disabled
@Test
public void canSuggestStaticallyTypedDocuments() throws IOException {
createHotelIndex();
Expand Down Expand Up @@ -216,7 +214,7 @@ public void testCanSuggestWithMinimumCoverage() throws IOException {
.assertNext(this::verifyMinimumCoverage)
.verifyComplete();
}
@Disabled

@Test
public void testTopTrimsResults() throws IOException {
createHotelIndex();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
import com.azure.search.test.environment.models.Book;
import io.netty.handler.codec.http.HttpResponseStatus;
import org.junit.Assert;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;

import java.io.IOException;
Expand All @@ -29,7 +28,6 @@ public class SuggestSyncTests extends SuggestTestBase {

private SearchIndexClient client;

@Disabled
@Test
public void canSuggestDynamicDocuments() throws IOException {
createHotelIndex();
Expand Down Expand Up @@ -105,7 +103,6 @@ public void canGetFuzzySuggestions() throws IOException {
Assert.assertFalse(suggestResultIterator.hasNext());
}

@Disabled
@Test
public void canSuggestStaticallyTypedDocuments() throws IOException {
createHotelIndex();
Expand Down Expand Up @@ -229,7 +226,6 @@ public void testCanSuggestWithMinimumCoverage() throws IOException {

}

@Disabled
@Test
public void testTopTrimsResults() throws IOException {
createHotelIndex();
Expand Down

0 comments on commit f85e4aa

Please sign in to comment.