generated from actions/typescript-action
-
Notifications
You must be signed in to change notification settings - Fork 3
Issue 72 fix git language bug #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MegaLinter status:
|
| Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
|---|---|---|---|---|---|
| ✅ ACTION | actionlint | 5 | 0 | 0.17s | |
| ✅ COPYPASTE | jscpd | yes | no | 1.85s | |
| ✅ CREDENTIALS | secretlint | yes | no | 1.03s | |
| ✅ GIT | git_diff | yes | no | 0.02s | |
| ✅ JAVASCRIPT | standard | 1 | 0 | 0 | 1.49s |
| ✅ JSON | eslint-plugin-jsonc | 7 | 0 | 0 | 1.01s |
| ✅ JSON | jsonlint | 7 | 0 | 2.02s | |
| ✅ JSON | prettier | 7 | 0 | 0 | 1.38s |
| ✅ JSON | v8r | 7 | 0 | 8.32s | |
| markdownlint | 2 | 0 | 1 | 0.4s | |
| ✅ MARKDOWN | markdown-link-check | 2 | 0 | 2.36s | |
| ✅ MARKDOWN | markdown-table-formatter | 2 | 0 | 0 | 0.35s |
| ✅ SPELL | cspell | 81 | 0 | 3.92s | |
| ✅ SPELL | misspell | 81 | 0 | 0 | 0.17s |
| ✅ TYPESCRIPT | eslint | 54 | 0 | 0 | 14.38s |
| ✅ YAML | prettier | 8 | 0 | 0 | 1.65s |
| ✅ YAML | v8r | 8 | 0 | 9.47s | |
| ✅ YAML | yamllint | 8 | 0 | 0.34s |
See errors details in artifact MegaLinter reports on CI Job page
a58f0b5 to
c501671
Compare
c501671 to
6865a6b
Compare
josecelano
requested changes
Mar 9, 2022
Member
josecelano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @yeraydavidrodriguez it looks good to me but make sure we do not have any problem with relative paths.
josecelano
reviewed
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves the GIT language issues described on #72 .
The problems were:
A localized string search on the git-repo::hasCommits method. This was replaced by examining the returning error code from a git log command.
Relying on SimpleGit to check if a dir contains an initialized repo. SimpleGit does not perform this test reliably (as described here), we fixed it by examining the returning error code from a git status command.
Additionally, we perform sanitization on the shell commands (by checking if the string passed to it is an actual dir) and we include this same test in the gitRepoDir class initialization.