Skip to content

thiserror -> snafu#70

Merged
Synicix merged 9 commits intonauticalab:devfrom
guzman-raphael:snafu
Apr 14, 2025
Merged

thiserror -> snafu#70
Synicix merged 9 commits intonauticalab:devfrom
guzman-raphael:snafu

Conversation

@guzman-raphael
Copy link
Contributor

@guzman-raphael guzman-raphael commented Apr 3, 2025

Depends on #69

In this PR, we:

  1. Replacethiserror in favor of snafu for error handling
  2. Add backtraces on all errors if available i.e. respect RUST_BACKTRACE environment variable
  3. Inject additional contextual info on external errors that could use more help e.g. adding the path to std::io::Error when encountering No such file or directory (os error 2)
  4. Remove usage of OrcaError::from(Kind::..) since unneeded. ? automatically converts due to impl From<Kind> for OrcaError {..}.
  5. Add error tests
  6. Improve colors on warning messages
  7. Add cargo expand macro expansion CLI (useful in debugging)
  8. Fix diagram doc bug

@guzman-raphael guzman-raphael marked this pull request as ready for review April 9, 2025 01:05
@Synicix Synicix mentioned this pull request Apr 11, 2025
Copy link
Contributor

@Synicix Synicix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed by using it in failure mode PR

@Synicix Synicix merged commit ffe0945 into nauticalab:dev Apr 14, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants