Support ASIO and WAVEIN/WAVEOUT in .Net Core 3.0 #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to work thus far
…audiodemo doesn't
|
Build failure appears to suggest that CI needs to upgrade to .Net Core 3.0. |
|
Can confirm this build works and that the CI is at fault. |
|
thanks for this, and apologies for the delay - haven't had much time to work on NAudio recently. I just need to test and work out if I can get the Azure Devops build going. I think it might just be a case of needing to update the |
markheath
added a commit
that referenced
this pull request
Jan 31, 2020
Merged
DavidMartynWood
pushed a commit
to DavidMartynWood/NAudio
that referenced
this pull request
Jul 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #538 in spirit. Specifically, this PR brings the missing ASIO code into the .Net Standard build of NAudio, as well as the WaveIn and WaveOut code into the .Net Core 3.0 build.
The latter works because Windows Forms (used by WaveIn/WaveOut for message pumping: see NAudio/Wave/MmeInterop/WaveWindow.cs) is now supported by .Net Core 3.0 but not .Net Standard.
This PR also modifies the WPF and WinForms sample apps to multi-target for .Net Framework and .Net Core 3.0 to demonstrate the targeting changes.