-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc website updates #941
Misc website updates #941
Conversation
jasongao97
commented
Apr 22, 2024
•
edited
Loading
edited
- Add chapter opening figure with quote, resolve Incorporate Chapter Openings #940
- Keep the lighter theme color for decoration purpose, e.g. border / icon
- Add anchor links for thumbnails and titles on the examples page
- Add meta description for search engine optimization, which also improves the appearance when shared on social media, Social Sharing Preview Image + Title #938
✅ Deploy Preview for nature-of-code-2nd-edition ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for nature-of-code-pdf ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This is looking great! For the chapter openings, I would suggest the following:
Overall, I would like these openings to feel like they are something different, rather than the start of the written text of the chapter. The image can be emphasized but the caption and description should be minimized. @tuantinghuang feel free to offer any thoughts! |
This looks good! I was just comparing this to our Figma file, and some things that I notice -
Attaching images to compare @jasongao97 I can also help editing the css code, let me know if you would prefer that! Thank you! |
The font weight was 800, and I've adjusted it to 700. I also replaced the period with a colon.
I've reduced the font size and adjusted the line spacing. Could you assist on the CSS part? I'm unsure if the current number is appropriate, and also the spacing between the quote and the author's name?
Done!
I've slightly reduced the line spacing. |
There are some small open items in the discussion above (for example, font size / spacing for quotes), but I think it makes sense to merge this so we can review the production site during our meeting and file new issues for additional work. |