Allow hashes with slashes#20
Merged
Zhen-hao merged 1 commit intonatural-transformation:masterfrom Sep 1, 2023
Merged
Conversation
The base64 representation of the hash may contain a '/' character, which is invalid in filenames. Replacing it with '_' to avoid the problem.
Zhen-hao
approved these changes
Aug 30, 2023
Contributor
Author
|
Looking at this again I'm not sure how this could ever have been a problem, as the sha256sum is hex-encoded, not base64-encoded... but I'm fairly confident I saw it fail and get fixed. Planning to revert, test, and if I can't reproduce the original problem PR that revert. Sorry about the noise :) |
Collaborator
|
@raboof I thought the same, but if you're editing a Maybe that's why this is here? |
Contributor
Author
Hmm, possibly, don't remember doing that though |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The base64 representation of the hash may contain a '/' character, which is invalid in filenames. Replacing it with '_' to avoid the problem.