feat: connz: monitor pending bytes #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wallyqs
reviewed
May 17, 2019
| @@ -19,7 +19,7 @@ import ( | |||
| "testing" | |||
| "time" | |||
|
|
|||
| "github.com/nats-io/go-nats-streaming" | |||
| stan "github.com/nats-io/go-nats-streaming" | |||
There was a problem hiding this comment.
we should update this to github.com/nats-io/stan.go soon probably... can do after this PR if it does not affect the build
There was a problem hiding this comment.
dunno why it changed the import 🤔
|
awesome, thanks :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to be able to alert if
pending_bytesis close tomax_pending.I also fixed the streaming metrics so they have the same
server_idlabel as all other metrics (instead ofserver).I wanted to avoid too much cardinality, that's why I just reported one metric with the sum of all pending bytes. If you think its best to have them as separated metrics I can definitely change that.