Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add queue_name, is_durable, and is_offline labels to streaming subscription metrics #74

Merged
merged 1 commit into from
May 6, 2019
Merged

Add queue_name, is_durable, and is_offline labels to streaming subscription metrics #74

merged 1 commit into from
May 6, 2019

Conversation

andriy-bulynko
Copy link
Contributor

Fixes #73

Subscription metrics labels would look like this:

# HELP nss_chan_subs_last_sent Last message sent
# TYPE nss_chan_subs_last_sent gauge
nss_chan_subs_last_sent{channel="channel",client_id="client-1",inbox="_INBOX.T2B88EAB82CMU1KA6CQNFN",is_durable="false",is_offline="false",queue_name="",server="http://localhost:8222"} 11
nss_chan_subs_last_sent{channel="channel",client_id="client-2",inbox="_INBOX.ETVIKB62MKRTCNS55BWHU0",is_durable="true",is_offline="true",queue_name="some-durable-sub-name:some-queue-name",server="http://localhost:8222"} 11
nss_chan_subs_last_sent{channel="channel",client_id="client-3",inbox="_INBOX.T6R1F9PP8XMY9B6X7WPN6T",is_durable="false",is_offline="false",queue_name="some-queue-name",server="http://localhost:8222"} 11
# HELP nss_chan_subs_max_inflight Max in flight message count
# TYPE nss_chan_subs_max_inflight gauge
nss_chan_subs_max_inflight{channel="channel",client_id="client-1",inbox="_INBOX.T2B88EAB82CMU1KA6CQNFN",is_durable="false",is_offline="false",queue_name="",server="http://localhost:8222"} 16384
nss_chan_subs_max_inflight{channel="channel",client_id="client-2",inbox="_INBOX.ETVIKB62MKRTCNS55BWHU0",is_durable="true",is_offline="true",queue_name="some-durable-sub-name:some-queue-name",server="http://localhost:8222"} 16384
nss_chan_subs_max_inflight{channel="channel",client_id="client-3",inbox="_INBOX.T6R1F9PP8XMY9B6X7WPN6T",is_durable="false",is_offline="false",queue_name="some-queue-name",server="http://localhost:8222"} 16384
# HELP nss_chan_subs_pending_count Pending message count
# TYPE nss_chan_subs_pending_count gauge
nss_chan_subs_pending_count{channel="channel",client_id="client-1",inbox="_INBOX.T2B88EAB82CMU1KA6CQNFN",is_durable="false",is_offline="false",queue_name="",server="http://localhost:8222"} 0
nss_chan_subs_pending_count{channel="channel",client_id="client-2",inbox="_INBOX.ETVIKB62MKRTCNS55BWHU0",is_durable="true",is_offline="true",queue_name="some-durable-sub-name:some-queue-name",server="http://localhost:8222"} 0
nss_chan_subs_pending_count{channel="channel",client_id="client-3",inbox="_INBOX.T6R1F9PP8XMY9B6X7WPN6T",is_durable="false",is_offline="false",queue_name="some-queue-name",server="http://localhost:8222"} 0

@wallyqs wallyqs changed the title Add queue_name, is_durable, and is_offline labels to streaming subscription metreics Add queue_name, is_durable, and is_offline labels to streaming subscription metrics May 6, 2019
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@wallyqs wallyqs merged commit 15da6ff into nats-io:master May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: add queue_name, is_durable, and is_offline labels to streaming subscription metrics
2 participants