Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prefix to nats metrics with -prefix #64

Merged
merged 4 commits into from
Jul 11, 2019
Merged

Add prefix to nats metrics with -prefix #64

merged 4 commits into from
Jul 11, 2019

Conversation

psbarrales
Copy link
Contributor

Allow to add -prefix to all metrics from nats

ColinSullivan1
ColinSullivan1 requested changes Apr 29, 2019
View reviewed changes
Copy link
Member

@ColinSullivan1 ColinSullivan1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good! Can you add a test to verify the prefix is what is expected?

ColinSullivan1
ColinSullivan1 requested changes Apr 29, 2019
View reviewed changes
Copy link
Member

@ColinSullivan1 ColinSullivan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good! Can you add a test to verify the prefix is what is expected?

@wallyqs wallyqs mentioned this pull request Jun 28, 2019
Closed
@castocolina
Copy link

castocolina commented Jul 4, 2019 •
edited
Loading

@psbarrales Your PR have conflicts in README.md. I am using your code and works as expected ;-)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 90.043% when pulling a4de1c6 on psbarrales:master into ee177ad on nats-io:master.

@wallyqs
Copy link
Member

wallyqs commented Jul 11, 2019

Sorry for the delay, thanks for rebasing and updating. LGTM.

@wallyqs wallyqs merged commit 175cecf into nats-io:master Jul 11, 2019
@wallyqs
Copy link
Member

wallyqs commented Jul 11, 2019

Just noticed that connz needs extra handling, sending fix in a bit...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColinSullivan1 ColinSullivan1 ColinSullivan1 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@psbarrales @castocolina @coveralls @wallyqs @ColinSullivan1